Add a "max" button on trade modal | Voters

Add a "max" button on trade modal

complete

Hpayne

I would like to move all of my available token balance in a trade and not type in a number/get left with a bunch of dust. Ideally this can be done with one click of a button to populate the trade amount

August 30, 2023

0xFBL

marked this post as

complete

Shipped!

0xFBL

marked this post as

in progress

Had an engineering candidate ship the work required to unblock this. Hopefully will get the coming weeks to finish off some of the finer nuance to implementation.

0xFBL

Merged in a post:

Clickable balance amount to fill trade modal

PTT

@reedz.fox has requested via product discussion here. https://discord.com/channels/554694662431178782/1105258096588230698/1133491119238422570

"It would be helpful if the "Balance 0.x ETH" line could be clicked to output "max amount minus fee" :3"

October 9, 2023

0xFBL

marked this post as

under review

0xFBL

Just as context, we would like this too as a UX pattern but it's extremely tricky b/c of the surface area on the app.

Recently though, one of the things we unpacked here was that the native assets don't have a send max. This was creating a gigantic amount of app friction which is why we turned max off. That being said we keep poking around a way to do this. Post multi hop UI we should be spiking here. 🤝

giant kin

I prefer the .. click amount to auto fill. (but would it have to detect route and add/remove fee for gas etc?)

Willy Ogorzaly

Agreed. can understand there is some challenges with doing this when trading from a native token like ETH, but there's no reason we shouldn't be able to at least have a 'Max' button when trading from an ERC20 token

Reed

Willy Ogorzaly: For me personally I'm not that bothered by being exact on the sat to avoid dust tbh. It's more that I find it annoying having to sit down and dig the calculator out of the backback to try to figure out how much I have to send to be "in the right ballpark".

I just wanna click "Max" or "100%" and be confident that the tx will actually go through.

Willy Ogorzaly

agree with this too, it's a pain to type it all in yourself and even an approximate Max would be a big improvement. thanks for the added context

Reed

https://shapeshift.canny.io/feature-requests/p/clickable-balance-amount-to-fill-trade-modal the feature is already requested here too

Fireb0mb1

Agreed, seems like a standard in most UI and we had it previously.

I know there are some challenges with fee calculation for some assets/routes, but even filling the field with the max balance and producing an "Insufficient funds" quote seems better than no button and having to type/manually copy the whole amount.

Fireb0mb1

I used to use that feature, so I agree.
I think  there were some difficulties with some routes to compute the actual "Max" (like CoW Swap deducting the fees from the traded asset or something) and that's why it got removed.
I've seen other apps using the number anyways and let the user deal with accounting for fees, not sure which solution is the best in this case, but I do miss this feature after the swapper update.

→